Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link switching on click #58317

Closed
wants to merge 2 commits into from
Closed

Fix link switching on click #58317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
449dcf3
set the adding link to false on mouse down to allow the paragraph to …
draganescu Jan 26, 2024
4ca9bea
remove unused deps, better function naming
draganescu Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions packages/format-library/src/link/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function Edit( {
return;
}

function handleClick( event ) {
function handleMouseUp( event ) {
// There is a situation whereby there is an existing link in the rich text
// and the user clicks on the leftmost edge of that link and fails to activate
// the link format, but the click event still fires on the `<a>` element.
Expand All @@ -62,10 +62,22 @@ function Edit( {
setAddingLink( true );
}

editableContentElement.addEventListener( 'click', handleClick );
const handleMouseDown = () => {
setAddingLink( false );
};

editableContentElement.addEventListener( 'mousedown', handleMouseDown );
editableContentElement.addEventListener( 'mouseup', handleMouseUp );

return () => {
editableContentElement.removeEventListener( 'click', handleClick );
editableContentElement.removeEventListener(
'mousedown',
handleMouseDown
);
editableContentElement.removeEventListener(
'mouseup',
handleMouseUp
);
};
}, [ contentRef, isActive ] );

Expand Down
Loading