[Site Editor]: Always show the Styles navigation item
#50573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Site Editor
Mamaduka
approved these changes
May 12, 2023
There was a problem hiding this comment.
The change works as expected.
I tested it based on the spec from this comment - #50429 (comment). Using TT3 and emptytheme without variations.
|
Size Change: +249 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Personally, I don't like this change. I don't think the menu item should send you to a different page depending on what a theme contain or not. It's a very weird behavior that has the potential to confuse users. cc @jasmussen |
Apologies for missing this. I hear you. The alternative is to do this: 
The key here is that the styles menu item is always present for consistent navigation and to provide a deep-link shortcut to editing global styles. I also suspect this general problem with be transient as the Styles section is not meant to only ever house style variations. It is meant to house color palettes you can swap between, font pairings, variations, possibly other items, each as their own subsequent drilldown. |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #50429
This PR always displays the
Stylesnavigation item in site editor sidebar. If a theme has global style variations, clicking the menu item will display the GS screen in sidebar. If a theme doesn't have any, the.Stylesitem will open the Edit view, with the Global Styles panel open.Testing Instructions