From 410c062d83f074f0b196337bf4b24105b27e06dd Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Thu, 2 Mar 2023 09:56:09 +1100 Subject: [PATCH 1/2] Theme JSON: Clarify status of fixed position opt-in in appearance tools --- lib/class-wp-theme-json-gutenberg.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/class-wp-theme-json-gutenberg.php b/lib/class-wp-theme-json-gutenberg.php index 4d688bb5b8b83..3d73224734f0e 100644 --- a/lib/class-wp-theme-json-gutenberg.php +++ b/lib/class-wp-theme-json-gutenberg.php @@ -545,7 +545,7 @@ public static function get_element_class_name( $element ) { * Options that settings.appearanceTools enables. * * @since 6.0.0 - * @since 6.2.0 Added `position.fixed` and `position.sticky`. + * @since 6.2.0 Added `dimensions.minHeight` and `position.sticky`. * @var array */ const APPEARANCE_TOOLS_OPT_INS = array( @@ -555,7 +555,12 @@ public static function get_element_class_name( $element ) { array( 'border', 'width' ), array( 'color', 'link' ), array( 'dimensions', 'minHeight' ), + // BEGIN EXPERIMENTAL. + // Allow `position.fixed` to be opted-in by default. + // Sticky position support was backported to WordPress 6.2 in https://core.trac.wordpress.org/ticket/57618. + // While `fixed` was included as a valid setting, exposing it by default it still experimental. array( 'position', 'fixed' ), + // END EXPERIMENTAL. array( 'position', 'sticky' ), array( 'spacing', 'blockGap' ), array( 'spacing', 'margin' ), From 5ed96a5a8e514773ed0f00b44122582f157fae27 Mon Sep 17 00:00:00 2001 From: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Date: Thu, 2 Mar 2023 14:20:16 +1100 Subject: [PATCH 2/2] Fix typo Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> --- lib/class-wp-theme-json-gutenberg.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/class-wp-theme-json-gutenberg.php b/lib/class-wp-theme-json-gutenberg.php index 3d73224734f0e..4a6e44b9f74a2 100644 --- a/lib/class-wp-theme-json-gutenberg.php +++ b/lib/class-wp-theme-json-gutenberg.php @@ -558,7 +558,7 @@ public static function get_element_class_name( $element ) { // BEGIN EXPERIMENTAL. // Allow `position.fixed` to be opted-in by default. // Sticky position support was backported to WordPress 6.2 in https://core.trac.wordpress.org/ticket/57618. - // While `fixed` was included as a valid setting, exposing it by default it still experimental. + // While `fixed` was included as a valid setting, exposing it by default is still experimental. array( 'position', 'fixed' ), // END EXPERIMENTAL. array( 'position', 'sticky' ),