Navigation: fix invalid permissions warning by avoiding using trashed wp_navigation posts (JS implementation) #42982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
MaggieCabrera,
scruffian,
spacedmonkey,
adamziel,
draganescu and
ajlende
getdave
changed the title
|
Size Change: +1.54 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Aug 4, 2022
Because the hook exports consistent data about the resolution status of a menu. I don't want to pollute that with information status about the navigation menu's publish status. As far as we the consumer of the hook are concerned the Navigation menu is "missing". Internally the hook knows that that's because the post is trashed but we don't need to know. I'm trying to encapsulate that info. The only thing to consider is if someone did a |
draganescu
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
I think the reasoning @getdave had for "missing" as a hook function is good and the code otherwise does what it says on the tin.
|
This works as described in #42940, but the deleted nav still shows on the front end. Is that expected? |
Great catch. I pushed a change but didn't get a chance to fully test it. Please could you run through it? Feel free to merge when you're happy. |
scruffian
approved these changes
Aug 8, 2022
scruffian
deleted the
fix/nav-block-using-trashed-nav-posts-js-implementation
branch
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the Nav block to avoid it showing a permissions warning for posts which don't exist.
First reported in #42735 (review).
Alternative to #42940. See that PR for more details.
Why?
See #42940.
How?
Instead of ignoring the posts on the REST API end, this PR treats non-published posts as "missing" on the JavaScript side.
This avoids some of the misdirection and complexity of introducing changes to the REST API.
Testing Instructions
See #42940.
Screenshots or screencast
See #42940.