[Site Editor]: Persist new template's description on creation #41281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
mcsf,
Mamaduka,
youknowriad,
jameskoster and
kevin940726
|
Size Change: -5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ntsekouras
deleted the
fix/site-editor-persist-passed-description-on-template-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while working on #41189.
Currently when we create a new template in site editor the description is not persisted. This is because we handle
post_excerptinternally and we need to passdescriptionproperty at the REST request.In general I see that we don't have a single source of truth for template info(default templates client side, default templates server side, persisted template post type) and this results in inconsistencies. For example when you edit one these templates in the site editor, the description seemed to be working as expected, but it was not picked up by template post type.
Testing instructions
Front Page(depends on the theme you use andEmptyis a good one to test with).Before
Screen.Recording.2022-05-24.at.6.27.58.PM.mov
After
after.mov