Fix: Page patterns don't show when only one pattern is available. #40707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: -18 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
fix/page-patterns-dont-show-if-only-one-pattern-is-available
branch
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported here #40034 (comment) by @ryanwelcher where only a post content pattern did not made the modal appear. It removes code that was on longer needed and was merged by mistake.
Testing Instructions
On file lib/compat/wordpress-6.0/block-patterns-update.php I updated "Image at left" pattern to include post content:
I created a new page and verified the modal still appeared.
I removed all post-content patterns and verified no modal appears.