-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Navigation Link variations #24613
Closed
noisysocks
wants to merge
1
commit into
add/formats-categories-suggestions
from
try/dynamic-navigation-link-urls
Closed
WIP: Navigation Link variations #24613
noisysocks
wants to merge
1
commit into
add/formats-categories-suggestions
from
try/dynamic-navigation-link-urls
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +608 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
noisysocks
force-pushed
the
try/dynamic-navigation-link-urls
branch
from
August 19, 2020 06:40
a057ca4
to
dbe0aae
Compare
noisysocks
changed the title
WIP: Dynamic Navigation Link URLs
WIP: Navigation Link variations
Aug 19, 2020
noisysocks
force-pushed
the
try/dynamic-navigation-link-urls
branch
from
August 19, 2020 06:42
dbe0aae
to
b271299
Compare
noisysocks
force-pushed
the
try/dynamic-navigation-link-urls
branch
from
August 20, 2020 02:05
b271299
to
daac2ce
Compare
noisysocks
changed the base branch from
master
to
add/formats-categories-suggestions
August 20, 2020 02:06
I think we'll ultimately want all of the changes here but better to introduce them in smaller more focused PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an exploration of #22919 but ended up encompassing a few different semi-related things: