Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of .components-item-group CSS selector from edit-site components #67369

Closed
2 of 6 tasks
afercia opened this issue Nov 28, 2024 · 0 comments · Fixed by #67575
Closed
2 of 6 tasks

Remove usage of .components-item-group CSS selector from edit-site components #67369

afercia opened this issue Nov 28, 2024 · 0 comments · Fixed by #67575
Labels
[Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@afercia
Copy link
Contributor

afercia commented Nov 28, 2024

Description

Splitting this out from #67321 (comment)

Cc @t-hamano @jameskoster

CSS selectors that come from base components of the @wordpress/components package should not be used in other packages.

This is the only place in all of Gutenberg where the .components-item-group selector is used.
It should be replaced with a more specific and 'semantically' correct CSS class. The class should be applied to all the <ItemGroup> components used in the edit site navigation screen and all its sub-screens,

Introduced in #50767

.components-item-group {
margin-left: -$grid-unit-20;
margin-right: -$grid-unit-20;
}

Step-by-step reproduction instructions

  • Search in the codebase for usages of the .components-item-group CSS selector.
  • Observe there's only one usage in a component of the edit-site package.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
1 participant