Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP 6.5 RC1 - Partial Sync Patterns br0oken #59651

Closed
nick6352683 opened this issue Mar 6, 2024 · 3 comments
Closed

WP 6.5 RC1 - Partial Sync Patterns br0oken #59651

nick6352683 opened this issue Mar 6, 2024 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended

Comments

@nick6352683
Copy link

Description

This regression was introduced in WP 6.5 RC1:

  • The "Pattern Overrides" checkbox under the Advanced Tab does not show up in WP RC1.
  • Existing partial syncs set in the beta versions work fine, but because the overrides checkbox is missing you cannot make changes to the patterns as far as partial syncing goes.
  • Activating the Gutenberg plugin, the bug goes away and all is fine again.

I hope this will be fixed by March 26, and not punt it to WP 6.6.

Step-by-step reproduction instructions

With WP 6.5 RC1 installed:

  1. Try to make a partially synced pattern - you can't...
  2. Activate the Gutenberg plugin.
  3. Now try step 1 and create a partially synced pattern - now you can !

Screenshots, screen recording, code snippet

No response

Environment info

WP 6.5 RC1, Windows 10, Chrome, Xampp 7.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@nick6352683 nick6352683 added the [Type] Bug An existing feature does not function as intended label Mar 6, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Mar 7, 2024

Thanks for the report.

I was able to reproduce this problem. However, in my environment, the pattern override UI was not displayed even if I enabled Gutenberg trunk (17.9.0-rc.1). What version of the Gutenberg plugin are you using?

In any case, I think the problem with pattern overrides not being available in WP6.5 should be fixed, so I'll add it to the project board.

pattern-overrides

@talldan
Copy link
Contributor

talldan commented Mar 7, 2024

I realize it's confusing, but the change is intentional. A block now has to be given a name to be considered overridable.

There's a discussion happening in the pattern overrides issue about this change - #53705 (comment)

@talldan talldan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
@nick6352683
Copy link
Author

Thanks guys, as a coincidence this was posted 2 hours ago, https://make.wordpress.org/core/2024/03/07/unblocking-wp6-5-font-library-and-synced-pattern-overrides/ and it seems that the pattern overrides will be punted for WP 6.6, which is frustrating... once again 2 steps forward, 1 step back.... After @talldan explanation, in RC1, we never get that checkbox, but to make it partial syncing to work, all we have do is give any pattern you want to partial sync, a block name, and you are set.... Let's see what will happen in the next weeks or so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants