Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details view → Styles #50429

Closed
2 of 3 tasks
Tracked by #33094
jasmussen opened this issue May 8, 2023 · 18 comments · Fixed by #50573 or #51149
Closed
2 of 3 tasks
Tracked by #33094

Details view → Styles #50429

jasmussen opened this issue May 8, 2023 · 18 comments · Fixed by #50573 or #51149
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@jasmussen
Copy link
Contributor

jasmussen commented May 8, 2023

The Design → Styles view serves three purposes:

  • Surfacing style variations for quick switching
  • Surfacing a deep-link to the global styles panel in the edit view
  • Provide quick-access to style revisions

Variations

Image

If the theme does not offer style variations, then the view becomes rather empty and incongruent:

Image

We should improve this in a way that lets us keep the deep link to the global styles panel. A couple of ideas for what we could do:

  • Keep the drilldown, but change the verbiage when there are no style variations. Perhaps: Any style variations for your theme will show up here. For now you can click the edit button to edit style properties.
  • Remove the drilldown, and simply have the "Styles" link go directly to the edit view, with the global styles panel open.

Style book

Screenshot 2023-05-25 at 10 05 48

Revisions

For access to revisions, we can use the same design as other panels, positioned directly above the save button:

Screenshot 2023-05-25 at 10 02 54
  • Add revisions access

It would be nice to load the revisions UI into the sidebar itself, but in the short term it may be necessary to deep link to the revisions panel in the full-screen editor.

@jasmussen jasmussen converted this from a draft issue May 8, 2023
@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 8, 2023
@jasmussen jasmussen moved this from Needs issue to Needs feedback in 6.3 Design May 8, 2023
@jasmussen
Copy link
Contributor Author

CC: @WordPress/gutenberg-design

@mtias mtias changed the title Design → Styles: What to show when there are no style variations Details view → Styles May 8, 2023
@mtias mtias mentioned this issue May 8, 2023
57 tasks
@mtias
Copy link
Member

mtias commented May 8, 2023

Also consider referring to the work on revisions: #50089

@youknowriad
Copy link
Contributor

I think I saw a PR related to this recently #50329

Is this already fixed (I mean the menu item hidden when there's no style variations)

@jasmussen
Copy link
Contributor Author

Is this already fixed (I mean the menu item hidden when there's no style variations)

In my flurry to create issues I wasn't able to properly test.

But if there is, we still need the "Styles" item, to at minimum surface a deep link to the global styles panel.

@richtabor
Copy link
Member

richtabor commented May 8, 2023

I think I saw a PR related to this recently #50329

That's right. In trunk, if the theme does not offer style variations, then the Styles nav item is no longer available, per #50329:

CleanShot 2023-05-08 at 14 47 14

I think we should keep the Styles item and have the "Styles" action open the Edit view, with the Global Styles panel open (for now). And follow up with design explorations into adding the variations, revisions, and style book as navigation items within the Styles panel. Related: #50393

@richtabor
Copy link
Member

And perhaps consider labeling them "Theme variations", as they're within the Styles panel.

@youknowriad
Copy link
Contributor

cc @ntsekouras

@SaxonF
Copy link
Contributor

SaxonF commented May 9, 2023

+1 on always showing Styles regardless of whether there are variations. Navigation becomes unpredictable otherwise.

@ntsekouras ntsekouras self-assigned this May 12, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 12, 2023
@github-project-automation github-project-automation bot moved this from Needs feedback to Needs dev in 6.3 Design May 12, 2023
@ntsekouras ntsekouras moved this from Needs dev to Done in 6.3 Design May 12, 2023
@jameskoster
Copy link
Contributor

Re-opening as I've seen it suggested to include a deep link to the Style Book in this panel.

@jameskoster jameskoster reopened this May 12, 2023
@jameskoster jameskoster moved this from Done to Needs design, or refresh in 6.3 Design May 12, 2023
@ntsekouras

This comment was marked as outdated.

@jameskoster
Copy link
Contributor

@jameskoster do we have any?

We're working on it. If you'd prefer to tackle that in a separate issue I suppose it would be fine.

@ntsekouras
Copy link
Contributor

If you'd prefer to tackle that in a separate issue

It doesn't really matter. We can keep track of it here.

@jameskoster
Copy link
Contributor

Haha I just saw it's tracked in #50379 so we can close :D

@github-project-automation github-project-automation bot moved this from Needs design, or refresh to Needs dev in 6.3 Design May 12, 2023
@paaljoachim
Copy link
Contributor

Btw it would be nice to be able to drill down into each style and see what settings these are made up of. It gives a deeper understanding of how each style is created.

If we take this even further then each setting for a style could have an on/off toggle switch so the user can create a custom version of a style by turning off specific settings. By doing so creating another version of the style.

@jameskoster
Copy link
Contributor

Re-opening as we missed a detail here – access to style revisions. It can share the same design we've worked on for other panels, positioned at the bottom of the panel, just above the save button. I'll update the OP to include this task.

@andrewserong
Copy link
Contributor

Just double-checking, is the revisions item in the screenshot in this issue ready for dev now? I see there's also been some discussion over in #50924 about de-emphasising style variations, so wasn't sure which would be a good next task to pick up to help close out this issue.

@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels May 30, 2023
@jasmussen
Copy link
Contributor Author

Yep, the design should be ready to go Andrew, thanks for asking. I've updated the labels.

@andrewserong
Copy link
Contributor

I have a PR open to explore adding in the Revisions button over in #51149

@github-project-automation github-project-automation bot moved this from Done to Needs dev in 6.3 Design Jun 6, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jun 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jun 27, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
Status: Done
Status: Done
10 participants