Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: the Site Icon partially hides the navigate region blue outline focus style #50288

Open
afercia opened this issue May 3, 2023 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented May 3, 2023

Description

In the Site Editor, the Site Icon at the top left partially hides the blue outline focus style shown when navigating through the editor regions. Likely introduced, at least partially, in #47777

Site Editor in browse mode:

Screenshot 2023-05-03 at 13 51 50

Site Editor in edit mode

Screenshot 2023-05-03 at 13 52 30

For comparison: the blue outline in the Post Editor is fully visible:

Screenshot 2023-05-03 at 13 58 14

As noted in #47777 (comment), this is not the first time the navigate regions focus style breaks, and I'd really love to see some form of visual regression testing in place into this project. WordCamp Europe would be a good opportunity to have some in person conversation about it.

Step-by-step reproduction instructions

  • Go to the Site Editor.
  • Stay in Browse mode.
  • Use the keyboard shortcut Control + backtick or Control + Option + N to navigate through the editor regions (equivalent keyboard shortcuts are available for Windows).
  • Observe that while navigating thorugh the regions, the focused regions is highlighted with a blue outline.
  • Observe the Site Icon partially hides the blue outline.
  • Switch to Edit mode.
  • Repeat the steps above.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [a11y] Keyboard & Focus [Package] Edit Site /packages/edit-site labels May 3, 2023
@ciampo ciampo moved this to Todo in Andrew's onboarding May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants