Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor details panel: Add descriptions for key pages like homepage, posts page #48782

Closed
3 tasks
jameskoster opened this issue Mar 6, 2023 · 8 comments
Closed
3 tasks
Labels
Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Mar 6, 2023

#48739 added basic descriptions to pages:

Screenshot 2023-03-06 at 12 56 57

It works ok for generic pages, but we can elaborate and improve the experience for special pages like the Homepage, Posts Page, Privacy Policy page, etc. We should do this in a way that plugins can extend, for example WooCommerce might want a unique description for the Shop, Cart, and Checkout pages.

  • Homepage
  • Posts Page
  • Privacy Policy
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Mar 6, 2023
@jameskoster
Copy link
Contributor Author

Here are some ideas:

Homepage

This is your homepage, visitors will be shown this page when they visit thesiteurl.com.

In the future it would be nice to allow folks to change their homepage here.

Posts Page
This one is tricky, because it's not really a page. It's a redirect to either the Home or Index template.

This is your Posts Page or Blog Home. Visitors will see your latest posts when they view this page.

Privacy Policy
I'm not entirely sure why we have a setting for this, so it's a bit tricky to write a description.

@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Mar 6, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 6, 2023
@ndiego ndiego moved this from ❓ Triage to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 8, 2023
@priethor priethor added the [Type] Copy Issues or PRs that need copy editing assistance label Mar 22, 2023
@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Mar 22, 2023
@jameskoster jameskoster moved this to Needs feedback in 6.3 Design Mar 30, 2023
@jasmussen
Copy link
Contributor

This is your Posts Page or Blog Home. Visitors will see your latest posts when they view this page.

I wonder if this description could be contextual based on whether it actually acts as your homepage or not. And in relation to your other comment, I agree, it would be nice to be able to make this happen in context of it. Here's a drilldown detail that I don't really love in terms of the visuals, but which nevertheless tries to include a dropdown that would let you set the behavior of that particular page, i.e. set as homepage etc:

Screenshot 2023-04-12 at 14 31 31

Assuming we could do this, we could split in two descriptions. When the Posts Page is also your homepage:

This is your Posts Page. It is set as your homepage, so visitors will see your latest posts when they visit thesiteurl.com.

When the Posts Page is not your homepage:

This is your Posts Page or Blog Home. Visitors will see your latest posts when they view this page.

We might even be able to make those descriptions link to a "Site Settings" page from here, where you could change it. As discussed in #49597 (comment), it's unclear whether being able to set these special pages in drilldown detail pages could entirely replace the reading setting, or not:

Screenshot 2023-04-12 at 14 35 30

@jameskoster
Copy link
Contributor Author

The homepage settings are probably worth exploring in a dedicated issue, it's a gnarly one. For now I think it would be nice to simply update these descriptions to be more contextual when appropriate.

I wonder if this description could be contextual based on whether it actually acts as your homepage or not

I don't think so, because the 'Posts page' concept only exists when you're using a static home page. This is part of the aforementioned gnarly-ness xD

@Mamaduka
Copy link
Member

I'm going to punt this one for WP 6.3 as well. Improvements will introduce new strings. While there have been cases of changing strings in minor releases, they are still rare.

@Mamaduka Mamaduka moved this from 🐛 Punted to 6.2.1 to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Apr 13, 2023
@jasmussen
Copy link
Contributor

Taking a fresh stab based on the initial suggestions.

Homepage
This is your homepage, visitors will be shown this page when they visit thesiteurl.com.

Posts Page
This is your Posts Page or Blog Home. Visitors will see your latest posts when they view this page.

☝️ unchanged, seem good.

Privacy Policy
The Privacy Policy page can be an important component of your website, so as to comply with EU GDPR regulations. This page enables you to inform your site visitors about the collection, usage, and protection of their personal information, whether through the use of cookies or otherwise.

How about this?

@jameskoster
Copy link
Contributor Author

You know what, I think we can probably close this in favor of #50582. There's probably no need for both. What do you think?

@jasmussen
Copy link
Contributor

Sure, do we need to copy the privacy description over?

@jameskoster
Copy link
Contributor Author

I reckon we can use the same approach for that page, IE an icon instead of the description.

Probably fine to handle that one separately though... the icon might require some exploration, and since most privacy policy pages are most likely titled "Privacy policy", they're already easy to find.

@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks May 23, 2023
@github-project-automation github-project-automation bot moved this from 🎨 Needs design to ✅ Done in Gutenberg Phase 2: Customization Jun 7, 2023
@github-project-automation github-project-automation bot moved this from Needs feedback to Needs dev in 6.3 Design Jun 7, 2023
@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.3.x Editor Tasks Jun 7, 2023
@apeatling apeatling moved this from Needs dev to Done in 6.3 Design Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

4 participants