Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template inspector: Surface revisions panel #44503

Closed
jasmussen opened this issue Sep 27, 2022 · 9 comments · Fixed by #45215
Closed

Template inspector: Surface revisions panel #44503

jasmussen opened this issue Sep 27, 2022 · 9 comments · Fixed by #45215
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] History History, undo, redo, revisions, autosave. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Templates and template parts support revisions. We should surface these in the inspector for Templates and Template Parts, especially because those inspectors are already so empty.

It could be surfaced in the same way as it is in the post editor, just as a link to the revisions page:

Revisions in template inspector, just a link

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Feature] History History, undo, redo, revisions, autosave. [Block] Template Part Affects the Template Parts Block labels Sep 27, 2022
@carlomanf
Copy link

This was already requested at #36060

@mtias
Copy link
Member

mtias commented Oct 4, 2022

This is a quick win given revisions are already enabled just not exposed. A link to the revisions interface would provide a lot of value.

@mtias mtias added the Needs Dev Ready for, and needs developer efforts label Oct 4, 2022
@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 4, 2022
@priethor
Copy link
Contributor

priethor commented Oct 4, 2022

Should revisions be shown in during Template Editing Mode in the Post Editor? That might be a bit less direct than just adding revisions to the Site Editor sidebar, as during Template Editing Mode, the hidden sidebar belongs to the post context.

@mtias
Copy link
Member

mtias commented Oct 4, 2022

It should be added on the template tab, whenever that is displayed.

@georgeh
Copy link
Contributor

georgeh commented Oct 7, 2022

I'll take a look at this one

@georgeh georgeh self-assigned this Oct 7, 2022
@georgeh
Copy link
Contributor

georgeh commented Oct 12, 2022

It looks like the REST API is not returning links to the previous revisions of template parts, so we will have to add that before we can add this button. I'm looking into adding that

@georgeh
Copy link
Contributor

georgeh commented Oct 28, 2022

This is mostly ready to go, but is blocked by a bug in the REST routes for template revisions. The CSS on #45215 could use some cleanup, though.

@jordesign
Copy link
Contributor

Just checking in on the progress of this? Having these revisions surfaced in the Inspector would be fantastic!

@Mamaduka Mamaduka removed the Needs Dev Ready for, and needs developer efforts label Feb 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
@spacedmonkey
Copy link
Member

@draganescu @georgeh @priethor @ramonjd @Mamaduka Core patch is ready and needs code review before it get merged in WP 6.4 beta 3. Please can a look and test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] History History, undo, redo, revisions, autosave. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants