Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there isn't space on top and below the block, the toolbar overlaps the block #38409

Open
gigitux opened this issue Feb 1, 2022 · 4 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@gigitux
Copy link
Contributor

gigitux commented Feb 1, 2022

Description

Working on woocommerce/woocommerce-blocks#5581 we noticed a strange behavior about the toolbar position: when there isn't space on top and below the block, the toolbar overlaps the block.

This behavior could generate a not optimal great experience (see image 2 and image 3).

I discovered that this use-case is handled here.

Maybe a related issue is #37076.

Step-by-step reproduction instructions

  1. Be sure that you have activated a block theme.
  2. Go to Appearance > Site Editor > Template Parts > Header.
  3. Click on the main block.
  4. Check the position of the toolbar.

Screenshots, screen recording, code snippet

image
image
image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Feb 22, 2022
@nerrad
Copy link
Contributor

nerrad commented Mar 17, 2022

A couple more examples:

Header template part focused in the context of the full index template with a block in the header selected:

CleanShot 2022-03-17 at 13 23 26@2x

Just the header template part with the same block selected:
CleanShot 2022-03-17 at 13 23 36@2x

@cuemarie
Copy link

I ran into this issue as well and submitted it over in Automattic/wp-calypso#60971

Here's the recording I took that shows my experience trying to add/edit Social Icons within a Navigation Block, when editing just the header template part of my site (which is quite short):

153275238-3db375e8-323f-47a5-b012-1d14ff4b104c.mov

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Jun 8, 2022

I have seen this a couple of times when working on FSE templates with customers.

Here is a screencast:

Screen.Capture.on.2022-06-07.at.19-07-21.mp4

@cuemarie
Copy link

Looks like specifically the navigation block and overlapping toolbars is being discussed/worked on here: #40382

I'm not sure if this issue is the exact same, or a related issue but impacts other blocks as well, so leaving open for other to determine that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants