Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar position in navigation's overlay is odd #36701

Closed
mtias opened this issue Nov 21, 2021 · 5 comments
Closed

Toolbar position in navigation's overlay is odd #36701

mtias opened this issue Nov 21, 2021 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Nov 21, 2021

The position of the toolbar when working with the overlay portion of a navigation menu looks random:

Screenshot 2021-11-21 at 13 26 00

@mtias mtias added the [Block] Navigation Affects the Navigation Block label Nov 21, 2021
@jasmussen
Copy link
Contributor

The way this is "fixed" in the post editor, is that the overlay menu has a higher z-index than the block toolbar, covering it, the idea being that the block toolbar isn't useful to editing content inside (the mover controls aren't right, etc). That solution breaks in the site editor, as that's iframed and creates a stacking order that doesn't allow the menu overlay to be elevated above the block toolbar.

As a longer term solution, the contents of the overlay should probably be separately customizable to the menu itself, and could potentially be edited in "template part focus mode".

As a near term solution, I wonder:

  • Can we simply hide the block toolbar when this overlay is opened?
  • Can we force the "top toolbar" option when this is opened?
  • Perhaps a plan B if those fail, if we can attach a classname to the block toolbar when the overlay is opened, we can likely improve things from this state at least.

@jasmussen
Copy link
Contributor

CC: @georgeh @vcanales @mkaz

@annezazu
Copy link
Contributor

I also experienced some oddness with the UX when using the always on mobile option today that I think relates to this issue as well:

nav.block.mobile.menu.mov

From my point of view, I thought the vertical alignment was accidentally turned on and that somehow the navigation block had taken over my entire header. It wasn't quite clear how to get out of it and the scroll bar that suddenly appeared made everything feel very broken.

@jasmussen
Copy link
Contributor

#36990 linked by github right above mitigates, but does not solve this one.

@mtias
Copy link
Member Author

mtias commented Sep 29, 2024

Closing as the entire overlay is due for a revision

@mtias mtias closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants