Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undoing Site Editor Navigation Actions Doesn't Undo the Action #34273

Closed
2 tasks done
bbertucc opened this issue Aug 24, 2021 · 1 comment
Closed
2 tasks done

Undoing Site Editor Navigation Actions Doesn't Undo the Action #34273

bbertucc opened this issue Aug 24, 2021 · 1 comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@bbertucc
Copy link

Description

Undoing Site Editor Navigation Actions Doesn't Undo the Action, specifically when adding a page link as a sub page in the navigation block

Step-by-step reproduction instructions

I'm following FSE Program Testing Call #9.. I accidentally nested a page link under another link in the navigation block. Immediately after doing this, I tried to undo my action but command-z only reloaded the editor page. Nothing was undone.

Screenshots, screen recording, code snippet

No response

Environment info

using the reccomended enviornment in FSE Program Testing Call #9 with Chrome Version 92.0.4515.159 on macOS v.11.4

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@annezazu annezazu added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block [Type] Bug An existing feature does not function as intended labels Aug 25, 2021
@talldan
Copy link
Contributor

talldan commented Oct 14, 2021

I think this may have been fixed by #34565.

When I tested there's now no problem with undo/redo. I'll close the issue, but reply to mention if you're still having issues in the latest version of Gutenberg, @bbertucc.

@talldan talldan closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants