Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Add a way to control button padding #31731

Closed
alaczek opened this issue May 11, 2021 · 4 comments
Closed

Buttons Block: Add a way to control button padding #31731

alaczek opened this issue May 11, 2021 · 4 comments
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@alaczek
Copy link

alaczek commented May 11, 2021

It would be useful to have padding controls for individual buttons. We recently added font-size controls, which is a great start, but having padding controls would give us full creative freedom independent of the theme. This would be especially useful when the theme is setting large padding on buttons by default making it impossible to create smaller, compact buttons.

Here's an example from the Seedlet theme.
If I wanted to create a button like this:
image
it would not be possible, because the theme sets default button padding at 23px. So even if I adjusted font-size, it would look like this:
image

Somewhat related to: #29098

@skorasaurus skorasaurus added [Type] Enhancement A suggestion for improvement. [Block] Buttons Affects the Buttons Block labels May 12, 2021
@paaljoachim
Copy link
Contributor

paaljoachim commented Jul 12, 2021

I am pinging @aaronrobertshaw about this issue. As he is currently working on associated padding/margin dimension controls.

@aaronrobertshaw
Copy link
Contributor

Thanks for the ping @paaljoachim.

@stacimc has done some great work on adding the padding support to buttons in #31774. I believe we just need to give that a final review then it shouldn't be far off landing. I'll find some time in the coming days to give it a test.

@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Jul 30, 2021
@mtias mtias mentioned this issue Jul 30, 2021
65 tasks
@apeatling
Copy link
Contributor

Axial padding support is now in place for the buttons block. #33859

@apeatling apeatling moved this to ⏱ Not Started in Design Tools Project Nov 2, 2021
@apeatling apeatling moved this from ⏱ Not Started to ✅ Done in Design Tools Project Nov 2, 2021
@apeatling
Copy link
Contributor

Also referencing axial padding support here #33859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

8 participants