-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SocialLinks block to the Navigation block #25016
Comments
A first step for anyone interested in pick this up would be to update the gutenberg/packages/block-library/src/navigation/edit.js Lines 182 to 185 in bd8bfea
There may also be styling issues when social links is rendered in Navigation, but that can always be addressed in a separate PR. |
I'm happy to jump in and get my feet wet with this one. |
That'd be great, thanks @jordesign! |
Allowing the nav block works well enough 👍 I'm wondering if we need to worry/think about the fact the alignment controls for the Social Links block don't make much sense in the context of a Nav Block? At the moment you can set an alignment on the Social Icons which breaks the layout in the editor. This doesn't seem to impact things on the front-end (testing with TwentyTwenty) but it seems it needs to be a nicer experience in the editor? |
Is it possible to hide the alignment options when the Social Links block is place within the Navigation block? |
@shaunandrews That's essentially what I was thinking too. I'm not sure of the answer though 😂. |
@jordesign I assigned this to you. Be sure to mention the issue when you open a PR with your work above thank you 🙏 |
@jordesign That's an interesting one. I don't think there's a good way to achieve this at the moment. The problem you've outlined is a bit higher level than this issue, and probably needs some discussion and potentially a new API for blocks. I think it'd be good to create your PR as is, and move the discussion on this on problem to a separate issue. |
PR is added ^ Will open a new issue regarding controlling whether alignment tools show when the block is inserted. |
Closed by #25357 |
Description
Part of #24875
We should add the ability to place a
SocialLinks
block to a navigation block. Currently we can add a search block.The text was updated successfully, but these errors were encountered: