Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu block: can not move keyboard focus to the 'Add Navigation Link' inserter button. #20741

Closed
enriquesanchez opened this issue Mar 9, 2020 · 4 comments
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@enriquesanchez
Copy link
Contributor

enriquesanchez commented Mar 9, 2020

As part of the accessibility test performed by the Accessibility team (#20369) we found that keyboard-only navigation in the navigation menu block was lacking.

One of the most critical issues was the inability to move keyboard focus to the 'Add Navigation Link' inserter button:

2020-03-09 14-16-04 2020-03-09 14_19_22

In the example above, after focusing on the 'Sample page" item, focus skips the inserter button and instead jumps to the sidebar. Similarly, shift-tab returns focus from the sidebar to the 'Sample page' item, skipping the inserter button.

@enriquesanchez enriquesanchez added the [Block] Navigation Affects the Navigation Block label Mar 9, 2020
@enriquesanchez
Copy link
Contributor Author

Perhaps a quick solution for this would be to have the 'Add link' label also show up even if you only have one menu item:

Screen Shot 2020-03-09 at 14 42 25

@mtias
Copy link
Member

mtias commented Mar 9, 2020

Would this be the same as #20728 ?

@enriquesanchez
Copy link
Contributor Author

It's very similar, yes.

In this particular case, moving keyboard focus to the inserter button was not possible. In addition, only after adding more than one menu item, the 'Add link...' label appears.

Once this label is present then keyboard focus works as expected.

@skorasaurus skorasaurus added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Dec 17, 2021
@tellthemachines
Copy link
Contributor

Closing this as it has been fixed by #37637.

Note: if "contain text cursor inside block" is enabled, it still won't work, but that's tracked separately as part of #36710, as it requires finding an alternative to Arrow key navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

4 participants