Skip to content

Commit

Permalink
Pull request automation: use full npm install (#66314)
Browse files Browse the repository at this point in the history
Remove single-package installation from this workflow that creates problems
when migrating to npm workspaces.

The regular npm install workflow is frequently available in cache.

---

Co-authored-by: sirreal <[email protected]>
Co-authored-by: gziolo <[email protected]>
# Conflicts:
#	.github/workflows/pull-request-automation.yml
  • Loading branch information
sirreal authored and getdave committed Oct 25, 2024
1 parent 61dbdc4 commit effc538
Showing 1 changed file with 2 additions and 18 deletions.
20 changes: 2 additions & 18 deletions .github/workflows/pull-request-automation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,8 @@ jobs:
ref: trunk
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}

- name: Use desired version of Node.js
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
node-version-file: '.nvmrc'
check-latest: true

- name: Cache NPM packages
uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
with:
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-node-${{ matrix.node }}-npm-pr-automation-cache-${{ hashFiles('**/package-lock.json') }}

# Changing into the action's directory and running `npm install` is much
# faster than a full project-wide `npm ci`.
- name: Install NPM dependencies
run: npm install
working-directory: packages/project-management-automation
- name: Setup Node.js and install dependencies
uses: ./.github/setup-node

- uses: ./packages/project-management-automation
with:
Expand Down

0 comments on commit effc538

Please sign in to comment.