Remove unstable max pages attribute from Nav block (#36877)

* Move to attr on Page List and remove from Nav block * Use empty check incase attr is falsey but present
WordPress · Nov 26, 2021 · c9e32e0 · c9e32e0
1 parent d7a0066
commit c9e32e0
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/packages/block-library/src/navigation/block.json b/packages/block-library/src/navigation/block.json
@@ -55,9 +55,6 @@
 		},
 		"customOverlayTextColor": {
 			"type": "string"
-		},
-		"__unstableMaxPages": {
-			"type": "number"
 		}
 	},
 	"usesContext": [ "navigationArea" ],
@@ -75,8 +72,7 @@
 		"showSubmenuIcon": "showSubmenuIcon",
 		"openSubmenusOnClick": "openSubmenusOnClick",
 		"style": "style",
-		"orientation": "orientation",
-		"__unstableMaxPages": "__unstableMaxPages"
+		"orientation": "orientation"
 	},
 	"supports": {
 		"align": [ "wide", "full" ],

diff --git a/packages/block-library/src/navigation/index.php b/packages/block-library/src/navigation/index.php
@@ -192,7 +192,9 @@ function block_core_navigation_get_fallback_blocks() {
 	$page_list_fallback = array(
 		array(
 			'blockName' => 'core/page-list',
-			'attrs'     => array(),
+			'attrs'     => array(
+				'__unstableMaxPages' => 4,
+			),
 		),
 	);
 
@@ -314,8 +316,7 @@ function render_block_core_navigation( $attributes, $content, $block ) {
 
 	// If there are no inner blocks then fallback to rendering an appropriate fallback.
 	if ( empty( $inner_blocks ) ) {
-		$is_fallback                      = true; // indicate we are rendering the fallback.
-		$attributes['__unstableMaxPages'] = 4; // set value to be passed as context to Page List block.
+		$is_fallback = true; // indicate we are rendering the fallback.
 
 		$fallback_blocks = block_core_navigation_get_fallback_blocks();
 

diff --git a/packages/block-library/src/page-list/block.json b/packages/block-library/src/page-list/block.json
@@ -7,7 +7,11 @@
 	"description": "Display a list of all pages.",
 	"keywords": [ "menu", "navigation" ],
 	"textdomain": "default",
-	"attributes": {},
+	"attributes": {
+		"__unstableMaxPages": {
+			"type": "number"
+		}
+	},
 	"usesContext": [
 		"textColor",
 		"customTextColor",
@@ -21,8 +25,7 @@
 		"customFontSize",
 		"showSubmenuIcon",
 		"style",
-		"openSubmenusOnClick",
-		"__unstableMaxPages"
+		"openSubmenusOnClick"
 	],
 	"supports": {
 		"reusable": false,

diff --git a/packages/block-library/src/page-list/index.php b/packages/block-library/src/page-list/index.php
@@ -293,8 +293,9 @@ function render_block_core_page_list( $attributes, $content, $block ) {
 
 	$nested_pages = block_core_page_list_nest_pages( $top_level_pages, $pages_with_children );
 
-	if ( array_key_exists( '__unstableMaxPages', $block->context ) ) {
-		$nested_pages = array_slice( $nested_pages, 0, $block->context['__unstableMaxPages'] );
+	// Limit the number of items to be visually displayed.
+	if ( ! empty( $attributes['__unstableMaxPages'] ) ) {
+		$nested_pages = array_slice( $nested_pages, 0, $attributes['__unstableMaxPages'] );
 	}
 
 	$is_navigation_child = array_key_exists( 'showSubmenuIcon', $block->context );