From b3fe0837a9a4412aaf1c5c560ce02b02d1fa17db Mon Sep 17 00:00:00 2001
From: Ella <4710635+ellatrix@users.noreply.github.com>
Date: Mon, 2 Dec 2024 16:07:57 +0100
Subject: [PATCH] useEditorTitle: fix wrong request without ID (#67475)

Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
---
 .../src/components/editor/use-editor-title.js |  4 ++
 test/e2e/specs/site-editor/preload.spec.js    | 41 +++++++++++++++++++
 2 files changed, 45 insertions(+)
 create mode 100644 test/e2e/specs/site-editor/preload.spec.js

diff --git a/packages/edit-site/src/components/editor/use-editor-title.js b/packages/edit-site/src/components/editor/use-editor-title.js
index 727b190117e02a..6f0b36f8e3b8b6 100644
--- a/packages/edit-site/src/components/editor/use-editor-title.js
+++ b/packages/edit-site/src/components/editor/use-editor-title.js
@@ -22,6 +22,10 @@ function useEditorTitle( postType, postId ) {
 			const { getEditedEntityRecord, hasFinishedResolution } =
 				select( coreStore );
 
+			if ( ! postId ) {
+				return { isLoaded: false };
+			}
+
 			const _record = getEditedEntityRecord(
 				'postType',
 				postType,
diff --git a/test/e2e/specs/site-editor/preload.spec.js b/test/e2e/specs/site-editor/preload.spec.js
new file mode 100644
index 00000000000000..1e93f783a8a91d
--- /dev/null
+++ b/test/e2e/specs/site-editor/preload.spec.js
@@ -0,0 +1,41 @@
+/**
+ * WordPress dependencies
+ */
+const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );
+
+test.describe( 'Preload', () => {
+	test.beforeAll( async ( { requestUtils } ) => {
+		await requestUtils.activateTheme( 'emptytheme' );
+	} );
+
+	test.afterAll( async ( { requestUtils } ) => {
+		await requestUtils.activateTheme( 'twentytwentyone' );
+	} );
+
+	test( 'Should make no requests before the iframe is loaded', async ( {
+		page,
+		admin,
+	} ) => {
+		// Do not use `visitSiteEditor` because it waits for the iframe to load.
+		await admin.visitAdminPage( 'site-editor.php' );
+
+		const requests = [];
+		let isLoaded = false;
+
+		page.on( 'request', ( request ) => {
+			if ( request.resourceType() === 'document' ) {
+				// The iframe also "requests" a blob document. This is the most
+				// reliable way to wait for the iframe to start loading.
+				// `waitForSelector` is always a bit delayed, and we don't want
+				// to detect requests after the iframe mounts.
+				isLoaded = true;
+			} else if ( ! isLoaded && request.resourceType() === 'fetch' ) {
+				requests.push( request.url() );
+			}
+		} );
+
+		await page.waitForFunction( ( _isLoaded ) => _isLoaded, [ isLoaded ] );
+
+		expect( requests ).toEqual( [] );
+	} );
+} );