Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Black Bordered Radius Block Variation and Pattern About Page #211

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

maurodf0
Copy link
Contributor

Add register block style for image with black bordered radius image.

maurodf0 added 2 commits June 14, 2024 00:23
Add register block style for image with black bordered radius image.
Add Patterns, assets ad images folder, add about full page pattern, image use block style variation created in WordPress#211
@maurodf0 maurodf0 changed the title Add Black Bordered Radius Block Variation Add Black Bordered Radius Block Variation and Pattern About Page Jun 13, 2024
array(
'name' => 'bordered',
'label' => __('Bordered', 'term'),
'inline_style' => '.wp-block-image.is-style-bordered img{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this because we can already use the border controls on the image block. We only did it for the social icons because those controls are not there yet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason being: a user can only opt in or out of the border radius, they can't tweak it to other values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, don't think about it, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants