Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay.onceComplete can fire "after" stop() #63

Open
ronkorving opened this issue Aug 1, 2017 · 2 comments
Open

Delay.onceComplete can fire "after" stop() #63

ronkorving opened this issue Aug 1, 2017 · 2 comments

Comments

@ronkorving
Copy link

ronkorving commented Aug 1, 2017 •
edited
Loading

Expected output:

Stopping myDelay
Stopped myDelay

Actual output (50% of the time):

myDelay.onceComplete called
Stopping myDelay
Stopped myDelay

Sample code:

<!doctype html>
<html>
<head>
  <script type="text/javascript" src="./tina.js"></script>
</head>
<body>

<script>
  var duration = 3;

  var myDelay = new TINA.Delay(duration);
  myDelay.onceComplete(function () {
    console.log('myDelay.onceComplete called');
  });
  myDelay.start();

  var d2 = new TINA.Delay(0); // bug also appears with a delay of 1
  d2.onceComplete(function () {
    console.log('Stopping myDelay');
    myDelay.stop();
    console.log('Stopped myDelay');
  });
  d2.start();
</script>

</body>
</html>
@ronkorving ronkorving changed the title Delay.onceComplete does not fire predictably Delay.onceComplete can fire after stop() Aug 1, 2017
@ronkorving ronkorving changed the title Delay.onceComplete can fire after stop() Delay.onceComplete can fire "after" stop() Aug 1, 2017
@ronkorving
Copy link
Author

Discussed this yesterday with @cainmartin and @jrouault and I believe the consensus on this at the moment is (correct me if I'm wrong) the following.

The resolution of event emission order is no smaller than a single tick. If both onceComplete events land in the same tick, the order is likely to be consistently first-registered followed by 2nd-registered (so we see "myDelay.onceComplete called" first). But sometimes, the two events will be in separate ticks, in which case the longer delay will always be in the 2nd tick and thus be stopped correctly.

This is probably as-good-as-it-gets, and I personally don't consider this an issue with TINA.

@ronkorving
Copy link
Author

After further investigation, we decided that an elegant solution would be to allow a tween to be destroyed, even if active, avoiding its events being emitted from that moment on. @jrouault will submit a pull request to expose such functionality.

@jrouault jrouault mentioned this issue Aug 2, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronkorving