Weird code in Sequence

[ronkorving]

Inside the Sequence.prototype._reconstruct method, there is a weird piece of code. link

if (activePlayableHandle !== null) {
  // Determining where to set the sequence's starting time so that the local time within
  // the active playable remains the same
  var currentStartTime = this._getStartTime();
  var timeInActiveAfter = this._time - activePlayable._getStartTime();
  var shift = timeInActiveBefore - timeInActiveAfter;
  this._startTime += shift;
}

Note how currentStartTime is being set by this._getStartTime() and then never gets used. "Instead" (or maybe they have no relation and I'm missing the point), on the next line activePlayable._getStartTime() is used.

One of two things seem to be true:

• var currentStartTime = this._getStartTime(); can be removed, behavior remains equal.
• activePlayable._getStartTime() should be replaced with currentStartTime, changing the behavior.

I have no idea which, but something's up here, and deserves attention.

[bchevalier]

I think it used to be

this._startTime = currentStartTime  + shift;

but because this._getStartTime() returns this._startTime it could be simplified and currentStartTime was not removed.

The global problem here is that TINA needs a linter

[ronkorving]

It seems there is a linter. But is it used?