Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setInterval callback is not invoked with provided args/thisArg #6

Closed
JamesMGreene opened this issue Oct 20, 2017 · 0 comments
Closed

setInterval callback is not invoked with provided args/thisArg #6

JamesMGreene opened this issue Oct 20, 2017 · 0 comments

Comments

@JamesMGreene
Copy link
Contributor

The setInterval callback is not invoked with provided args/thisArg

This is addressed in one of the multiple commits in pending PR #1 but there are other things in the PR holding that one back from being merged.
@JamesMGreene JamesMGreene mentioned this issue Oct 20, 2017
Merged
ronkorving pushed a commit that referenced this issue Oct 23, 2017
@JamesMGreene
fix: ensure setInterval honors args and thisArg
c44286c 
Fixes #6

Also strengthened the unit tests for setTimeout and setTimeoutAt
to also ensure the same behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesMGreene