-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: API parity with clearTimeout and clearInterval #4
Comments
I'd also really like to see these added as I am going to recommend that known consumers of my older module |
@ronkorving: Thoughts on this one? |
Sure, sounds good 👍 This also works in the browser: var t = setTimeout(function () { console.log('fired'); }, 10);
clearInterval(t);
|
@ronkorving: Well, the browsers' behavior is really just an implementation shortcut/quirk rather than a guaranteed spec-compliant behavior. Regardless, if you are suggesting to keep this module's implementation similarly loose (which it seems like you are), then I'm fine with that. |
What are your thoughts on completing API parity with the core Timers APIs by adding the top-level methods
clearTimeout
andclearInterval
to this module's API?Obviously it would be simple to do so:
Happy to submit a PR for this, plus unit tests, if you're good with the suggestion.
The text was updated successfully, but these errors were encountered: