Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question About Impl of CopyAndAssignCidr #3

Open
ffproxy opened this issue Mar 22, 2022 · 0 comments
Open

Question About Impl of CopyAndAssignCidr #3

ffproxy opened this issue Mar 22, 2022 · 0 comments

Comments

@ffproxy
Copy link

ffproxy commented Mar 22, 2022

Hello,

I did not understand about the whole allocdips.c implementation , But the line below seems a bug .

Especially on line allowedips.c:39 as below:
#if REG_DWORD == REG_DWORD_LITTLE_ENDIAN
Node->BitAtA ^= (Bits / 8U - 1U) % 8U;
#endif

In my understanding, It should be

#if REG_DWORD == REG_DWORD_LITTLE_ENDIAN
Node->BitAtA &= (Bits / 8U - 1U) % 8U;
#endif

Appreciate, Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant