Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix react favIcon inconsistency issue #953

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erinz2020
Copy link
Contributor

favIcon should be consistency across the site. call useDocumentTitle hook in FrontDesk.jsx so all react pages use the same favIcon from /api/v3/site-settings

PR fixes #952

@erinz2020 erinz2020 added this to the 10.6.0 milestone Dec 19, 2024
@erinz2020 erinz2020 self-assigned this Dec 19, 2024
Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FavIcon Inconsistency Across React Pages
2 participants