Add ?teach parameter to see instructor version of homepage regardless of user role (#5812) #5983
Conversation
…atus during onboarding - Added `teach` parameter to the onboarding flow to allow users to override the absence of the instructor role, especially for those coming through enrollment links. - Updated `onboard` method in `OnboardingController` to check for the `teach` parameter and grant instructor permissions when present. - Modified view logic to adjust button layouts and added styles for course creation and orientation review buttons on the dashboard.
|
This is different than what I had in mind. Rather than using the ?teach parameter for enrollment or onboarding links, I'd like the homepage itself to use that parameter to render the instructor version regardless of user role. The idea would be that we could include links to I think we could also optionally also automatically set the role from student to instructor, but the place to do that would be upon completion of the instructor orientation training module. |
…all users regardless of user role
… training modules
Abishekcs
changed the title
Abishekcs
changed the title
| @@ -31,6 +32,38 @@ def mark_exercise_complete | |||
|
|
|||
| private | |||
|
|
|||
| def instructor_training_complete? | |||
There was a problem hiding this comment.
This feature should not be in the same PR. I'd prefer to first merge the simplest possible version that will address the issue.
| @@ -15,6 +15,7 @@ def index | |||
| set_admin_courses_if_admin | |||
| @pres = DashboardPresenter.new(current_courses, past_courses, | |||
| @submitted, @strictly_current, current_user) | |||
| @instructor_view = params.key?(:teach) and user_signed_in? | |||
There was a problem hiding this comment.
I think the better way to handle this is inside the DashboardPresenter, by passing the 'teach' parameter to the presenter.
Using a separate instance variable makes it more complicated to get all the correct behaviors (such as showing the link to instructor orientation but not the create course button, if the user has not already completed that training module). With the presenter approach, I think there will be no changes needed in the view templates.
There was a problem hiding this comment.
Okay, I will make the required changes. Thank you for the review
closes #5812
What this PR does
This PR addresses issue #5812 by adding a
?teachparameter which allows homepage to use this parameter to render the instructor version of the homepage regardless of user role.Changes:
?teach
?teachparameter now allows to see instructor version of the homepage regardless of user role.Completion of instructor orientation training modules:
Dashboard Buttons:
Screenshots
Before:
Before.mp4
After:
After.mp4