Refactor some files to i18n format instead of hardcoded string literals #5980
+82
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This introduces some linting errors. |
Fixed! |
ragesoss
reviewed
Oct 8, 2024
| {text} | ||
| {remaining.length ? ( | ||
| <small> | ||
| {remaining.length} {I18n.t('training.remaining_exercise')} |
There was a problem hiding this comment.
Rather than concatenating the number with the message, this should be implemented as an argument to the message, so that translators have full control of how to handle the number within the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
Refactors some files to i18n format instead of hardcoded string literals
Fixes #5738
Screenshots
Before:
After:
