converting stream to buffer when uploading files without apparent need #922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the conversion is only being carried out to check the file size and compare it with the maximum size limit of the upload hosts. However, these hosts are returning
null
in themaxContentLengthBytes
field, because of this, the code becomes useless and generates a problem of intense RAM usage without need in cases of sending large files.I modified it to remove the size check (since it will never be checked since the value is null)
and I passed the stream directly to the axios request, so the file will be sent in stream mode, saving RAM