Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "else" in sendMessagesAgain to fix message resend/ #907

Closed
wants to merge 1 commit into from
Closed

remove "else" in sendMessagesAgain to fix message resend/ #907

wants to merge 1 commit into from

Conversation

keef3ar
Copy link

@keef3ar keef3ar commented Jul 4, 2024

Probably Fixes of resend message. (waiting for this message) #905

@whiskeysockets-bot
Copy link
Contributor

Thanks for your contribution.

The next step is to wait for review and approval to merge it to main repository

The community can help reacting with a thumb up (:thumbsup:) for approval and rocket (:rocket:) for who has tested it.

To test this PR you can run the following command below:

# NPM
npm install @whiskeysockets/baileys@keef3ar/Baileys#fix_resend_message
# YARN v2
yarn add @whiskeysockets/baileys@keef3ar/Baileys#fix_resend_message

@bobslavtriev
Copy link
Contributor

Don't change what you don't know, there are no problems with "waiting for this message", the problem is in your code!

@keef3ar
Copy link
Author

keef3ar commented Jul 4, 2024

Don't change what you don't know, there are no problems with "waiting for this message", the problem is in your code!

Problem reproduce even with example code.
I have 900+ sessions. This change fix "waiting for this message" in personal chats when libsignal session updating, i can see it in logs.

@azudindaem
Copy link
Contributor

azudindaem commented Jul 4, 2024

To make you understand,

The original code is like this:

if (isStupid) {
    learnMore = true;
} else {
    learnMore = false;
}

And you changed it to this:

if (isStupid) {
    learnMore = true;
} 

learnMore = false;

Just because your code works with a few changes, it doesn't mean your code is correct.

@keef3ar keef3ar closed this Jul 4, 2024
@keef3ar keef3ar deleted the fix_resend_message branch July 4, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants