Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility To Do List #1038

Open
scottkleinman opened this issue Jun 12, 2020 · 0 comments
Open

Accessibility To Do List #1038

scottkleinman opened this issue Jun 12, 2020 · 0 comments

Comments

@scottkleinman
Copy link
Contributor

scottkleinman commented Jun 12, 2020

The to do list below contains accessibility issues identified with the Wave Web Accessibility Evaluation Tool. This issue closes issue #849.

As of commit bacd013, all pages pass accessibility checks, although more work could be done on the issues below.

In general, there is an over-reliance on h3 for all sorts of labelling functions. Some of these have been eliminated because of accessibility requirements, but we could make more effort to make the remaining examples a little more semantic.

  • Themes have varying degrees of colour contrast. Grey Light is the only theme that passes accessibility standards. Perhaps in the future this could be modified, but in the meantime, the introductory popup and help text recommend the Grey Light theme.

  • In Manage, empty cells are marked by empty h3 elements. Not using html table markup prevents us from leveraging built-in accessibility attributes. It is possible to add `aria-labelledby="empty cell", but we would need to chase up all the Javascript that adds/removes content to make sure that this attribute is correctly toggled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant