Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom framerate? #7

Open
shiffman opened this issue Feb 12, 2019 · 6 comments
Open

Custom framerate? #7

shiffman opened this issue Feb 12, 2019 · 6 comments

Comments

@shiffman
Copy link
Contributor

The frame rate I don't believe is changing if I pass in a custom value in config, I am trying:

  recorder = p5Gif.capture({framerate: 60});

But the GIF appears to stick with the 10 FPS default?

Full code: https://editor.p5js.org/codingtrain/sketches/WfEih8mL7

@fffiloni
Copy link

fffiloni commented Feb 15, 2019

I found a way to overwrite settings :
After you initialized the recorder, set custom settings like this

recorder = p5Gif.capture();

 recorder.settings.width = 200;
 recorder.settings.height = 200;
 recorder.settings.framerate = 12;

This will work, until changes are made by the developers

@WenheLI
Copy link
Owner

WenheLI commented Feb 15, 2019

Actually, we currently forbid the framerate going beyond 20 fps. It is a concern of the run-time performance. If the fps is large, the time for saving gif will be quite long. We will see if we can tune up the fps restriction.

@WenheLI
Copy link
Owner

WenheLI commented Feb 20, 2019

@shiffman @fffiloni Thanks for your help. The custom framerate problem has been solved. I limited the upper framerate to 30 right now. Do you think it is still small? We originally thought a large framerate will make the browser crash.

@fffiloni
Copy link

fffiloni commented Mar 4, 2019

Hello !

It seems that the custom framerate is still not changing. In the recorder.settings.framerate we see it has changed, but then the gif that is created do not take this number.

My gif, once downloaded, are always at the same rate : 10.

Thanks for your help !

@fffiloni
Copy link

fffiloni commented Mar 4, 2019

maybe it is something involved with the delayvalue on the gif export ?

@fffiloni
Copy link

fffiloni commented Mar 4, 2019

i moved my last question into a new issue : #16
because i think its a new features request ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants