Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image orientation not being honoured for image #530

Open
Webreaper opened this issue Apr 29, 2024 · 10 comments
Open

Image orientation not being honoured for image #530

Webreaper opened this issue Apr 29, 2024 · 10 comments

Comments

@Webreaper
Copy link
Owner

Per @marijnv2000 :
File is too big to attach here.. See google drive link:
https://drive.google.com/file/d/1Tz6MqP_AWPCO5x7Yc1AC8eXbhLmwNLR6/view?usp=sharing

exiftool shows "Rotate 270 CW". Local image viewers open it up with the correct orientation, damselfly shows it sideways like this:

image

@Webreaper
Copy link
Owner Author

Looks like a SkiaSharp bug. I've reported it here: mono/SkiaSharp#2850

@Webreaper
Copy link
Owner Author

I''ve put in a temporary fix, which should solve your issue. @marijnv2000 can you pull webreaper/damselfly:dev and see if it solves it?

@marijnv2000
Copy link

@Webreaper sorry, took a while for me to get back to this. Thanks for looking into this.

I've changed to dev and it still doesn't rotate the image, neither in the thumbnail or when viewing the image. It does look to have solved the stretching issue for the thumbnail however, it now looks like this:
image

By the way, I'm happy to wait for the SkiaSharp issue to be fixed.

@Webreaper
Copy link
Owner Author

Did you refresh the thumbnails via the context menu? They won't be regenerated unless you do. It works fine for me.

@marijnv2000
Copy link

Yes, I did. Twice now :) Same result in the browser and the app, which I guess is expected, but still.
Not rotated

@Webreaper
Copy link
Owner Author

One other thing to try is pressing shift+refresh in the browser. It could be browser caching.

@marijnv2000
Copy link

Tried clearing cookies and site data for the domain, tried force refresh, tried private mode, tried a different browser that had never opened Damselfly before, and get the same result on all..

@Webreaper
Copy link
Owner Author

Dammit. Weird, wonder how it works for me?

@marijnv2000
Copy link

Weird indeed.. Any way to verify we're running the same code? I pulled the dev tag and saw some changes (notably the + on folder icons letting me expand/collapse them) so I assumed it worked correctly.

@Webreaper
Copy link
Owner Author

Definitely running the same code. I always run dev.

Possibly an OS thing, I haven't tried it on linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants