-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use the misleading name "One" for a singular form used for numbers other than 1 #9675
Comments
These are names defined by CLDR (see https://www.unicode.org/cldr/charts/40/supplemental/language_plural_rules.html#hr) and Weblate uses them for consistency with other tooling. Showing the examples more prominently might make it more clear, though. PS: There are languages where the same applies to “Two”, see https://www.unicode.org/cldr/charts/40/supplemental/language_plural_rules.html#dsb |
This issue has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this. You can learn about how to get started in our contributors documentation. |
Is this issue still open? I am looking to contribute to it. I am newbie. |
My impression is that these names are good as identifiers (in a database for example) but not very intuitive for humans who don't know them. Let me propose two alternatives:
I don't open pull request yet, I prefer to open the discussion (as I propose 2 solutions and you may like none of them). Also the patches do actually only treat the case of Croatian and languages with similar scheme: I will finish the work as newbee contribution as soon as we agree about the desired solution. Tell me what you think |
Instead of the tooltip, the text is rendered in the page now. Fixes WeblateOrg#9675
Many professional translators are used to these names, that's why I think the category names should stay visible. The specific rules are language dependent (and vary between file formats or framework versions), so I don't think it's reasonable to have a verbose description for each of them. So my original intention here was just to show the numbers directly, not only in a tooltip. This is what I've just implemented in #10136 |
I understand but
The fact that somebody (not me) opened such a ticket shows us that this is not the case for everybody.
As the rule can depend from the number, you may have exactly same problem to display the correct number. For example what if some languages make agreement for 21 as singular and some as genitive plural like 25? |
Instead of the tooltip, the text is rendered in the page now. Fixes WeblateOrg#9675
I'm not saying that everybody understands these, but it's an industry standard. Omitting that would be confusing for many users. We definitely need to clarify this for users not familiar with CLDR categories. |
Instead of the tooltip, the text is rendered in the page now. Fixes #9675
Thank you for your report; the issue you have reported has just been fixed.
|
Describe the problem
Consider the following English source string with plural form (from a PO file):
As you see, msgid uses "One apple" instead of "{count} apple", which is acceptable in English.
In other languages, however, the singular form may be used not only for 1. For example, in Russian, Ukrainian, Belarusian, Serbian, and Croatian the singular form is also used for numbers ending with 1. The problem with Webalte is that although it shows the right hint when you hover over the circled "i", the entry name literally says "One", which is simply not true for the mentioned languages:
Naturally, this misguides translators: they think that the message will be used for exactly 1 item, and create a translation that doesn't work with 21, 31, 41, etc. - that is, in the example source string above, they will use the analog of "One apple" instead of "{count} apple". After all, if the entry clearly says "one", why would anyone check the hint button?
Describe the solution you'd like
The entry label should probably not say "One", but instead include the example text currently hidden in (i).
Describe alternatives you've considered
No response
Screenshots
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: