Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumping to a specific page through pagination component in changes page would clear the date filter #6898

Closed
2 tasks done
Geeyun-JY3 opened this issue Dec 2, 2021 · 6 comments
Assignees
Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Milestone

Comments

@Geeyun-JY3
Copy link
Collaborator

Describe the issue

Entering number to jump to a specific page through pagination component in changes page would clear the date filter, including starting date and ending date filter.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to changes page
  2. Setting a date filter
  3. Click on the pagination component
  4. Enter a number than go
  5. The date filter is cleared

Expected behavior

The date filter wouldn't be cleared.

Screenshots

weblate_pagination1

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added bug Something is broken. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. labels Dec 3, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@ejgonzalez17
Copy link

Hi, I would like to take this issue to start contributing to your project.

@nijel
Copy link
Member

nijel commented Dec 19, 2021

@ejgonzalez17 you are welcome

@nijel nijel added the hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. label Sep 19, 2022
@Geeyun-JY3
Copy link
Collaborator Author

This bug seems fixed after 08a5c15 (?) implemented.

@nijel nijel added this to the 5.0 milestone Aug 24, 2023
@nijel
Copy link
Member

nijel commented Aug 24, 2023

Indeed it was fixed.

@nijel nijel closed this as completed Aug 24, 2023
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

3 participants