Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI customization not applied to some elements #12966

Closed
2 tasks done
nijel opened this issue Nov 8, 2024 · 3 comments · Fixed by #13007
Closed
2 tasks done

UI customization not applied to some elements #12966

nijel opened this issue Nov 8, 2024 · 3 comments · Fixed by #13007
Assignees
@meel-hd
Labels
bug Something is broken. ux Issues related to user experience.

Comments

@nijel
Copy link
Member

nijel commented Nov 8, 2024

Describe the issue

Some elements (at least SVG images in navbar) are wrongly styled after #12613

Now:

obrazek

Before:

obrazek

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Have UI customization configured
  2. Upgrade

Expected behavior

No response

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Git checkout

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response
@nijel nijel added bug Something is broken. ux Issues related to user experience. labels Nov 8, 2024
@meel-hd
Copy link
Collaborator

meel-hd commented Nov 8, 2024

I remember that was intentional. The icons on the right side of the navigation weren't affected by the custom color text settings. Unfortunately that affects the logo too. I'm thinking maybe the logo should always stay in the green brand color. What do you think?

@nijel
Copy link
Member Author

nijel commented Nov 8, 2024

It affects navigation icons on the right side as well. Also, the logo is not using brand color, it is using navbar color.

meel-hd added a commit to meel-hd/weblate that referenced this issue Nov 13, 2024
@meel-hd
fix(styles): update navbar svg color to match header text color
09c54f4 
close: WeblateOrg#12966
@meel-hd meel-hd mentioned this issue Nov 13, 2024
Merged
5 tasks
nijel pushed a commit that referenced this issue Nov 13, 2024
@meel-hd
fix(styles): update navbar svg color to match header text color (#13007)
cd34add 
* fix(styles): update navbar svg color to match header text color

close: #12966

* fix(styles): add space after 'fill' property in custom.css
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meel-hd meel-hd

Labels
bug Something is broken. ux Issues related to user experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(styles): update navbar svg color to match header text color meel-hd/weblate
2 participants
@nijel @meel-hd