Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread safety #33

Open
xzackli opened this issue Jun 6, 2023 · 0 comments
Open

thread safety #33

xzackli opened this issue Jun 6, 2023 · 0 comments

Comments

@xzackli
Copy link
Collaborator

xzackli commented Jun 6, 2023

XGPaint until this point has been used on very large sky areas and a huge number of halos. Shared-memory calculations where multiple threads mutate one shared array has been ok, because the sources in each thread's chunk are super far away from each other on the sky.

Now that we're generating smaller patches, we should probably make a small workspace structure that holds a copy of the map for each thread.

Then we'll add up the final maps at the end. For large maps, it still makes sense not to make 32 copies of the full sky, so we should probably have an option to do what XGPaint currently does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant