Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate interpolator generation for model from source generation #23

Open
dongwooc opened this issue Jun 1, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@dongwooc
Copy link
Contributor

dongwooc commented Jun 1, 2023

at the moment get_interpolators runs every time generate_sources happens. this results in an inefficiency that is admittedly very minor, but if interpolator generation becomes expensive for whatever reason at some future point, for chunked runs it is likely more performant to generate interpolators once for the whole halo catalogue and then pass that to the per-chunk function each time.

@dongwooc dongwooc added the enhancement New feature or request label Jun 1, 2023
@xzackli
Copy link
Collaborator

xzackli commented Jun 7, 2023

Yes, @dongwooc I'd propose to make the interfaces across all models similar to the tsz model

  1. Configuration type contains model input parameters
  2. Create a source workspace type based on model (contains interpolators but also source information, has empty! implemented to reset source realization
  3. Create workspace type for maps, different for each pixelization
  4. Call paint! on map, passing the two workspaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants