Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have better names and purposes for the Benchmark classes #73

Open
shallawa opened this issue Sep 11, 2024 · 0 comments
Open

Have better names and purposes for the Benchmark classes #73

shallawa opened this issue Sep 11, 2024 · 0 comments

Comments

@shallawa
Copy link
Contributor

Currently we have these class

  1. benchmarkController
  2. benchmarkRunnerClient
  3. BenchmarkRunner
  4. BenchmarkRunnerState
  5. ResultsDashboard
  6. ResultsTable
  7. DeveloperResultsTable

benchmarkController and benchmarkRunnerClient are extended a little bit more for the debug page. It is hard to know what each class is doing. Extending the class for the debug page seems old-fashioned as well.

I would suggest the following hierarchy:

  1. Motionmark: this acts like the app class. It detects the screen orientation, the frame rate and decides the best stage size. It shows the test frame and calls the Benchmark to run the tests and then it collects the results
  2. Benchmark: It runs all the test by loading the test frame, collecting the results and removing the test frame
  3. Results: It holds the results of running the tests. It is generated by Benchmark and consumed by MotionMark
  4. ReleaseMotionmark: a super class of MotionMark
  5. DebugMotionmark: a super class of MotionMark
  6. DebugReults: a super class of Results
  7. DebugRampResults: a super class of DebugResults
  8. DebugFixedResults: a super class of DebugResults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant