Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clang builtins for threads targets #494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Clang builtins for threads targets #494

wants to merge 3 commits into from

Commits on Oct 18, 2024

  1. Add Clang builtins for threads targets 

    This change adds the `libclang_rt.builtins-wasm32.a` to the appropriate
Clang directory for the threaded variants of the WASI targets
(`lib/wasi-threads`, `lib/wasip1-threads`). This fixes #543.
    @abrown
    abrown committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    021e8dc View commit details
    Browse the repository at this point in the history

  2. Add test using a compiler builtin 

    This uses the `__floatditf` function which was reported as an issue in
[wasi-libc#543]. Compiling and running this test should prove that the
builtins are available in the `wasm32-*-threads` targets as long as the
tests use those targets (they do, right?).

[wasi-libc#543]: WebAssembly/wasi-libc#543
    @abrown
    abrown committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    38ae65b View commit details
    Browse the repository at this point in the history

  3. Switch test to use __floatdidf 

    The `__floatdidf` builtin uses a more conventional type--`double`--which
means we don't have to guess at the representation of `tf_float`.
    @abrown
    abrown committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    24a7308 View commit details
    Browse the repository at this point in the history