Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -fno-strict-aliasing for emmalloc #424

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

cuviper
Copy link
Contributor

@cuviper cuviper commented Jun 23, 2023

emmalloc uses a lot of pointer type-punning, which is UB under strict aliasing.

Fixes #421.

Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through all the discussion in #421 and this makes sense to me. Thanks for figuring this out!

@abrown abrown merged commit bd950eb into WebAssembly:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memory fault in emmalloc prev_region
2 participants