[js-api] Add tests for WebAssembly.JSTag #319
Conversation
This adds tests for `WebAssembly.JSTag`. The tests are adapted from https://github.com/v8/v8/blob/main/test/mjsunit/wasm/exnref-api.js. Confirmed that they run successfully with web test infrastructure in Chrome with `--js-flags=--experimental-wasm-exnref` command line argument. The only thing failing there was the shadowrealm test, which I think we should add a separate expectation files like the existing `***.tentative.any.shadowrealm-expected.txt` in https://github.com/chromium/chromium/tree/main/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception. But given that we don't host these files in this EH repo, I'll just upload the js files.
|
|
||
| test(() => { | ||
| assert_throws_js(TypeError, () => new WebAssembly.Exception(WebAssembly.JSTag, [{}])) | ||
| }, "Creating a WebAssembly.Exception with JSTag explicitly is not allowed"); |
There was a problem hiding this comment.
Here I'm showing my lack of knowledge about the details of the test infra, but does this assertion check the exact text of the error message? The spec mandates what kind of exception should be thrown (TypeError), but not the text.
There was a problem hiding this comment.
I don't think this string is checked against anything else. So I just used it to describe what the tests were about. Maybe I'm abusing it? 🤷🏻
There was a problem hiding this comment.
Yeah, I think it's fine as long as the test won't fail because of different error messages.
There was a problem hiding this comment.
Yeah, this is just the name of the subtest.
| } | ||
| const buffer = builder.toBuffer(); | ||
| const {instance} = await WebAssembly.instantiate(buffer, { | ||
| module: { throw_ref, JSTag: WebAssembly.JSTag } |
There was a problem hiding this comment.
should this be throw_ref: throw_ref,?
There was a problem hiding this comment.
That works, but it looks in case the imported name and the external name are the same, just writing it once seems to have the same effect.
There was a problem hiding this comment.
Yeah, this is the shorthand syntax in JS object initializers.
|
|
||
| test(() => { | ||
| assert_throws_js(TypeError, () => new WebAssembly.Exception(WebAssembly.JSTag, [{}])) | ||
| }, "Creating a WebAssembly.Exception with JSTag explicitly is not allowed"); |
There was a problem hiding this comment.
Yeah, this is just the name of the subtest.
| } | ||
| const buffer = builder.toBuffer(); | ||
| const {instance} = await WebAssembly.instantiate(buffer, { | ||
| module: { throw_ref, JSTag: WebAssembly.JSTag } |
There was a problem hiding this comment.
Yeah, this is the shorthand syntax in JS object initializers.
| }); | ||
|
|
||
| const obj = {}; | ||
| const wasmTag = new WebAssembly.Tag({parameters:['externref']}); |
There was a problem hiding this comment.
This appears unused in this subtest.
This adds tests for
WebAssembly.JSTag. The tests are adapted from https://github.com/v8/v8/blob/main/test/mjsunit/wasm/exnref-api.js.Confirmed that they run successfully with web test infrastructure in Chrome with
--js-flags=--experimental-wasm-exnrefcommand line argument. The only thing failing there was the shadowrealm test, which I think we should add a separate expectation files like the existing***.tentative.any.shadowrealm-expected.txtinhttps://github.com/chromium/chromium/tree/main/third_party/blink/web_tests/external/wpt/wasm/jsapi/exception. But given that we don't host these files in this EH repo, I'll just upload the js files.