Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an activity stream item when a user has donated #4

Open
BoweFrankema opened this issue Apr 10, 2015 · 8 comments
Open

Add an activity stream item when a user has donated #4

BoweFrankema opened this issue Apr 10, 2015 · 8 comments
Assignees
Milestone

Comments

@BoweFrankema
Copy link
Member

It would be something like in the example below

screenshot 2015-04-10 11 08 10

Admin settings

Default update text
If there is no custom donation message attached let the admin specify a default message that gets added as an update

Visibility
Will the donation be shown to all members of the site or only to the friends of the person who donated?

Show Hide/Donation Amount
Do you want to show the donation amount made by the user?

That's it for now!

@henrywright
Copy link
Contributor

We could let the donor choose the visibility? For example, when they are completing the donation form, we could output radio buttons which give the options: a) Hide from activity b) Show for friends only c) Show site-wide.

The same could go for the Show/Hide donation amount option. We could let the donor specify this when completing the form?

The only issue I can see with giving a donar these choices is the extra effort involved for them when making the donation. Making donations should be as simple and effort-free as possible, so another form field (or two) might be a bad idea.

@BoweFrankema
Copy link
Member Author

I think this should be up to the admin to decide. In my case I don't want to everyone to know when someone donates because it gets in the way of the content. I do think it's cool to show when people are already friends. But this completely depends on the community. So maybe this should be an admin controlled option?

I also want to minimise confusion during the donation process and not ask this question during checkout. Another option would be show a screen after a successful donation.

Thanks for your donation!

Tell the world you are supporting CFCommunity by sharing it with your friends elsewhere:

[social sharing buttons]

or share it with your friends on CFCommunity (if a user is logged in)

[share on CFCommunity form]

So that would make sharing optional but still encouraged!

@henrywright
Copy link
Contributor

I think you're right to want to minimise confusion during the donation process, anything trivial can happen after the transaction has taken place. I like the idea of share options on the confirmation page, there's nothing to stop us adding that functionality after we've got the basics in place.

So regarding the admin options, it might be worth thinking where is the best place for the admin options screen. Should we have it within the Donations menu item added by the Give plugin, or should we have it elsewhere, such as under Settings > BuddyPress and then have a dedicated tab alongside Components, Pages and Settings?

@BoweFrankema
Copy link
Member Author

I would say that we would try and integrate into the GiveWP using their available hooks. So add it under Donations as new menu item. Something like "BuddyPress-on" under "Donations".

Or maybe under Donations > Settings > BuddyPress Add-on

This way people who are new to Give (which is more logical at this point) can set up and configure the entire plugin from one panel instead of hopping around.

@henrywright
Copy link
Contributor

OK great.

@henrywright
Copy link
Contributor

This is now pretty much done. There's some things I've spotted that I'll need to clean up:

  • Donation message needs to be made optional.
  • Use a currency symbol in the activity item text instead of the abbreviation.
  • Use a textarea field instead of text box where appropriate
  • Add the custom donation message to the confirmation page ..

@BoweFrankema
Copy link
Member Author

One other small issue is the activity stream message contains the username and not the Nice Name of the user. Also the name is not hyperlinked. See the following screenshot:

screenshot 2015-04-16 11 15 34

@henrywright
Copy link
Contributor

These outstanding issues have now been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants