Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

walletkit-ui - Migrate to shared components #13

Open
13 of 15 tasks
thedoublejay opened this issue Dec 15, 2022 · 2 comments
Open
13 of 15 tasks

walletkit-ui - Migrate to shared components #13

thedoublejay opened this issue Dec 15, 2022 · 2 comments
Labels
area/workflow kind/feature New feature request triage/accepted Triage has been accepted

Comments

@thedoublejay
Copy link
Member

thedoublejay commented Dec 15, 2022

What would you like to be added:

The goal of this library is to able to share components between different products/consumers. Example, WhaleContext is used on Mobile Light Wallet and Desktop Light Wallet. We would want to migrate it on this library, and use them on both products.

Another thing for consideration when moving, if the current context/store etc have functionalities that can be used on other products which are not specific to react. Consider moving them to @walletkit-core. So if we want to use them on Bridge (server side), we can use them without importing React. Example, @lykalabrada moved some WhaleContext logic to whale.ts - https://github.com/WavesHQ/walletkit/pull/6/files

After migrating, you can update them on both Desktop Light Wallet and Mobile Light Wallet.
Example:

  1. https://github.com/WavesHQ/desktop-light-wallet/pull/296
  2. feature(walletkit-ui): migrate NetworkContext BirthdayResearch/defichain-wallet#3842

Don't forget to test!

For up to date logic, please get the files on Mobile Light Wallet.

Providers

Store

@thedoublejay thedoublejay added the kind/feature New feature request label Dec 15, 2022
@github-actions
Copy link

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the WavesHQ developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Dec 15, 2022
@github-actions
Copy link

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the WavesHQ developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@thedoublejay thedoublejay added triage/accepted Triage has been accepted area/workflow and removed needs/area Needs area label(s) needs/triage Waiting for triage to be accepted labels Dec 15, 2022
@thedoublejay thedoublejay pinned this issue Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/workflow kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

1 participant