Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize error handling #405

Open
VendettaReborn opened this issue May 14, 2024 · 5 comments
Open

Optimize error handling #405

VendettaReborn opened this issue May 14, 2024 · 5 comments

Comments

@VendettaReborn
Copy link
Contributor

Motivations: greptimedb has done an excellent job in error handling, see: https://greptime.com/blogs/2024-05-07-error-rust
Shall we adopt some ideas from it?

@ibigbug
Copy link
Member

ibigbug commented May 15, 2024

yeah the stack trace looks nice. i'd be up for using it

@VendettaReborn
Copy link
Contributor Author

demo code, i've written a simple demo, mostly based on greptimedb's impl, since they haven't published the error handling crate yet, it shall be much more convenient to take a glance at their ideas of virtual user stack , the blog is already pasted above

@ibigbug
Copy link
Member

ibigbug commented Aug 17, 2024

Nice! Planning to make a crate for this?

@VendettaReborn
Copy link
Contributor Author

Nnope, the idea belongs to greptime db, i just wondered how easily can we adopt it in our project. Is this way of error handling better from your point of view? After which i shall start the refactor in this project.

@ibigbug
Copy link
Member

ibigbug commented Aug 18, 2024

Ok makes sense.

Yeah I like it, seems clean way to track error stack and easier to report the where the error originates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants