-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: The linter is not the same as the original repo #117
Comments
Seems like the build check on push and on PR are duplicated. |
@adithyaakrishna Can you please take a look? Thanks. |
@hydai We are using this Lint workflow Workflow File: https://github.com/WasmEdge/docs/blob/main/.github/workflows/lint.yml |
Hi @adithyaakrishna However, the eslint doesn't enable the markdown plugin. |
Ohh that makes sense, does this workflow auto commits the changes as well? |
No idea. We don't do auto commits in the main repo, but it should have if you use the markdown plugin with eslint. |
Fixed and Updated in the above PR :) |
Bug: The linter is not the same as the original repo
|
@alabulei1 What kind of enhancement do we need to do? |
We should use a markdown linter in the workflow to detect the linting issue. |
Describe the bug.
The original repo applied markdown-lint with a custom configuration file.
Configuration file
https://github.com/WasmEdge/WasmEdge/blob/master/.github/linters/.markdown-lint.yml
Just save it as
.markdownlint.yaml
.Error log
Describe the steps to reproduce the behavior.
Install markdownlint
Run markdwonlint with given configuration file
markdownlint-cli2 "**/*.md"
Expected behavior.
Let's refine the configuration file or apply markdown-lint to ensure all markdown files follow the same spec.
Screenshots.
No response
Operating Environment
ProductName:macOS ProductVersion:13.4.1 BuildVersion:22F82
Additional Information
No response
The text was updated successfully, but these errors were encountered: