-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trackless tracking #120
Open
RoelN
wants to merge
1
commit into
master
Choose a base branch
from
add-tracking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,9 @@ | |
<meta property="og:image" content="https://wakamaifondue.com/wf-screenshot-square.jpg" /> | ||
<link rel="icon" type="image/svg+xml" href="<%= BASE_URL %>favicon.svg"> | ||
<title>Wakamai Fondue, the tool that answers the question “what can my font do?”</title> | ||
<script defer | ||
src="//wakamaifondue.trackless.app/analytics.js" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just checking: this doesn't use cookies? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't! But see also my other comment. :) |
||
></script> | ||
</head> | ||
<body> | ||
<!-- | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that navigating to https://trackless.app reveals virtually nothing about what this system is and searching for it seems nearly impossible because more popular things with these terms seem to come up first, I suggest documenting what this is in an HTML comment next to this script load so people with concerns can review what is being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to give a bit of context: the URL is from a side project of mine for an app for privacy-friendly (and cookieless) analytics, but it's still (very) early days and it doesn't have a website yet.
This is great feedback though and I understand the concerns, so maybe it's a good idea to close this PR or put it on hold until I have some online information about what it is, what it tracks, and what it doesn't track? (I hope to have something soon!) // @RoelN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I know this is a tracker built with the best intentions by a developer I trust, but it's good to clarify this to other users as well. I'll put this PR on hold for now.